Rename math functions to strict_add/strict_sub #2107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webmaster128
force-pushed
the
rename-to-strict_
branch
from
0617609 to
a4a872d
Compare
chipshort
approved these changes
Apr 11, 2024
Contributor
chipshort
left a comment
chipshort
left a comment
There was a problem hiding this comment.
LGTM, didn't know about these in Rust std
Member
Author
|
@mergify backport release/2.0 release/1.5 release/1.4 |
Contributor
✅ Backports have been createdDetails
|
mergify bot
pushed a commit
that referenced
this pull request
Apr 11, 2024
(cherry picked from commit 3b59561) # Conflicts: # CHANGELOG.md
mergify bot
pushed a commit
that referenced
this pull request
Apr 11, 2024
(cherry picked from commit 3b59561) # Conflicts: # CHANGELOG.md
This was referenced Apr 11, 2024
mergify bot
pushed a commit
that referenced
this pull request
Apr 11, 2024
(cherry picked from commit 3b59561) # Conflicts: # CHANGELOG.md # packages/std/src/math/uint128.rs # packages/std/src/math/uint256.rs # packages/std/src/math/uint512.rs # packages/std/src/math/uint64.rs
webmaster128
added a commit
that referenced
this pull request
Apr 15, 2024
* Rename math functions to strict_add/strict_sub (#2107) (cherry picked from commit 3b59561) # Conflicts: # CHANGELOG.md # packages/std/src/math/uint128.rs # packages/std/src/math/uint256.rs # packages/std/src/math/uint512.rs # packages/std/src/math/uint64.rs * Fix test code from merge * Fix CHANGELOG --------- Co-authored-by: Simon Warta <[email protected]> Co-authored-by: Simon Warta <[email protected]>
webmaster128
added a commit
that referenced
this pull request
Apr 15, 2024
* Rename math functions to strict_add/strict_sub (#2107) (cherry picked from commit 3b59561) # Conflicts: # CHANGELOG.md * Fix CHANGELOG --------- Co-authored-by: Simon Warta <[email protected]> Co-authored-by: Simon Warta <[email protected]>
webmaster128
added a commit
that referenced
this pull request
Apr 15, 2024
* Rename math functions to strict_add/strict_sub (#2107) (cherry picked from commit 3b59561) # Conflicts: # CHANGELOG.md * Fix CHANGELOG * Add ### Changed section to Unreleased CHANGELOG --------- Co-authored-by: Simon Warta <[email protected]> Co-authored-by: Simon Warta <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out the Rust standard library add the functions from #2098 under a different name. See rust-lang/rust#118260. Since this was not yet release, we can use those names too.